Fix E501, F541, and F841 for a_proposalhelper, a_proprevhelper, a_todohelper

regolith/helpers/a_proposalhelper.py

@@ -132,7 +132,6 @@ def construct_global_ctx(self):
         gtx["zip"] = zip
 
     def db_updater(self):
-        gtx = self.gtx
         rc = self.rc
         if rc.date:
             now = date_parser.parse(rc.date).date()
@@ -168,7 +167,7 @@ def db_updater(self):
                     ):
                         # assuming that the user inputs the correct duration up to 1 decimal place
                         # so the maximum allowed difference is 0.1*30.5
-                        raise ValueError(f"ERROR: please rerun specifying a duration OR an end-date but not both")
+                        raise ValueError("ERROR: please rerun specifying a duration OR an end-date but not both")
             pdoc.update({"begin_date": begin_date})
         else:
             pdoc.update({"begin_date": "tbd"})

regolith/helpers/a_proprevhelper.py

@@ -23,7 +23,7 @@ def subparser(subpi):
         date_kwargs["widget"] = "DateChooser"
 
     subpi.add_argument("name", help="pi first name space last name in quotes", default=None)
-    subpi.add_argument("type", choices=ALLOWED_TYPES, help=f"Report type", default=None)
+    subpi.add_argument("type", choices=ALLOWED_TYPES, help="Report type", default=None)
     subpi.add_argument("due_date", help="Due date", **date_kwargs)
     subpi.add_argument(
         "-d",
@@ -32,7 +32,7 @@ def subparser(subpi):
     )
     subpi.add_argument("-q", "--requester", help="Name of the Program officer requesting")
     subpi.add_argument("-r", "--reviewer", help="name of the reviewer.  Defaults to sbillinge")
-    subpi.add_argument("-s", "--status", choices=ALLOWED_STATI, help=f"Report status", default="accepted")
+    subpi.add_argument("-s", "--status", choices=ALLOWED_STATI, help="Report status", default="accepted")
     subpi.add_argument("-t", "--title", help="the title of the proposal")
     return subpi
 

regolith/helpers/a_todohelper.py

@@ -9,7 +9,7 @@
 from regolith.fsclient import _id_key
 from regolith.tools import all_docs_from_collection, get_pi_id, get_uuid, fragment_retrieval
 from gooey import GooeyParser
-from sys import exit
+
 
 TARGET_COLL = "todos"
 ALLOWED_IMPORTANCE = [3, 2, 1, 0]
@@ -41,16 +41,16 @@ def subparser(subpi):
         "-d",
         "--deadline",
         action="store_true",
-        help=f"specify if the due date (above) has a hard deadline",
+        help="specify if the due date (above) has a hard deadline",
     )
     subpi.add_argument(
         "-m",
         "--importance",
         choices=ALLOWED_IMPORTANCE,
         type=int,
-        help=f"The importance of the task. "
-        f"Corresponds roughly to (3) tt, (2) tf, (1) ft, (0) ff in the Eisenhower matrix of "
-        f"importance vs. urgency.  An important and urgent task would be 3.",
+        help="The importance of the task. "
+        "Corresponds roughly to (3) tt, (2) tf, (1) ft, (0) ff in the Eisenhower matrix of "
+        "importance vs. urgency.  An important and urgent task would be 3.",
         default=1,
     )
     subpi.add_argument(
@@ -92,7 +92,8 @@ def subparser(subpi):
     )
     subpi.add_argument(
         "--date",
-        help="Enter a date such that the helper can calculate how many days are left from that date to the deadline. Default is today.",
+        help="Enter a date such that the helper can calculate how many days are left from that date to the deadline. "
+             "Default is today.",
         **date_kwargs,
     )
 
@@ -216,7 +217,8 @@ def db_updater(self):
                     mil.update({"tasks": []})
                 mil["tasks"].append(todo_uuid)
                 print(
-                    f"The milestone uuid {rc.milestone_uuid} in projectum {target_prum.get('_id')} has been updated in projecta."
+                    f"The milestone uuid {rc.milestone_uuid} in projectum {target_prum.get('_id')} has been "
+                    "updated in projecta."
                 )
             rc.client.update_one(rc.database, "projecta", {"_id": target_prum.get("_id")}, target_prum)
         indices = [todo.get("running_index", 0) for todo in todolist]