Fix E501 E266 E712 F821 in test_validate, test_validators, runcontrol, test_commands.py #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validate, test_validators, runcontrol, test_commands.py
sbillinge
reviewed
Jul 8, 2024
| @@ -38,9 +38,6 @@ def test_mongo_to_fs_python(make_mongo_to_fs_backup_db, make_mongodb): | |||
| main(["mongo-to-fs"]) | |||
| except Exception as e: | |||
| print(e) | |||
| assert True == False | |||
| else: | |||
| assert True == True | |||
There was a problem hiding this comment.
I think by deleting these lines you are changing behavior so it is probably not a good idea to change it.
If you simply chage the first to assert False and the second to assert True, does that remove the flake8 error? That would then not change the behavior.
Also, same for below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.