-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README.rst and conf.py update #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see inline comments.
README.rst
Outdated
Docs: | ||
----- | ||
https://regro.github.io/regolith-docs/ | ||
For more information on regolith please visit the project `web-page <https://regro.github.io/>`_ or email Prof. Simon Billinge at sb2896@columbia.edu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this link needs to be fixed. It is going to the wrong place.
from regolith import __version__ as REGOLITH_VERSION | ||
from regolith.fsclient import _id_key, dump_json, json_to_yaml | ||
from regolith.main import CONNECTED_COMMANDS, DISCONNECTED_COMMANDS | ||
from regolith.schemas import EXEMPLARS, SCHEMAS | ||
|
||
autodoc_mock_imports = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please can you double check that this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, otherwise it would run into issues like e.g. WARNING: autodoc: failed to import module '...' from module 'regolith'; the following exception was raised: No module named 'regolith'. Something like that. It is the solution that resolves this issue that gives in the api workflow.
Merge README.rst and conf.py (safe merge to api)