Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc/source files, change regolith.rst to index.rst in doc/source/api #1139

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

stevenhua0320
Copy link
Contributor

Merge these files.
Note that Merge PR #1138 first to make sure it would successfully work

… to index.rst and some content has changed to follow index.rst format
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really great, fantastic to see. Please can you check if there were any manual edits for typos that all of them are actually corrected in the original docstring and not just here? Otherwise they will be overwritten the next time the api workflow is run.

Maybe put those corrections on a separate PR

@@ -1,18 +1,24 @@
Contacts
========
a lighter version of people. Fewer required fieldsfor capturing people who are less tightly coupled
a lighter version of people. Fewer required fields for capturing people who are less tightly coupled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few typo's being fixed but presumably these typos were being made on the auto-build and will be overwritten next time the api workflow is run. Did you also make edits in the docstrings of the relevant module to also correct the mistake there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that the original typo comes from schemas.json, and the original typo has been fixed in previous lint check PR. I'm sure that in current version the api workflow follow the edited version and corrected the typo automatically here.

@sbillinge sbillinge merged commit 0e4d74a into regro:api Jul 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants