Include LICENSE file in the installed node_modules

[MarkAshraf96]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Problem

Including the license file in the installed node_modules, makes the packages compatible with license checkers and attribution file generators, that a lot of developers need for their work.

Solution

Add the license file in the package.json to the 'files' field of each package.

Alternatives

Nothing on my mind, that can replace that.

[wooorm]

License checkers should be able to look at the package.json? Do you use tools that don’t do that?

[wooorm]

I don’t think your solution works. If we link from files to ../../license, I’m quite sure that no license file will be packaged?

[remcohaszing]

We could either copy the license in the build scripts, or just copy the license into all packages once. We already include the license in packages in other monorepos, such as remark.

[MarkAshraf96]

License checkers should be able to look at the package.json? Do you use tools that don’t do that?

They are able to detect the license type, but they are not able to detect the license text, which is required for creating copyrights/attribution files.

I don’t think your solution works. If we link from files to ../../license, I’m quite sure that no license file will be packaged?

To be honest, I am not quiet sure that it would work or not. Another solution that I just bumped into in another monorepo, is just copying the license into all packages.

[MarkAshraf96]

We could either copy the license in the build scripts, or just copy the license into all packages once. We already include the license in packages in other monorepos, such as remark.

And micromark also, I believe you did the same.

[wooorm]

released!

[MarkAshraf96]

released!

Thank you a lot, another thing because I was looking also into doing the same in other repos that you are maintaining. Do you think it's good if you add the license file also to the installed packages?

[wooorm]

Sorry, I don’t understand your question. Can you rephrase please

[MarkAshraf96]

Yes sure,
I mean including the license files in the package distribution.
I believe it's also considered as a best practice.

[wooorm]

That’s what I just did? What is the question?

[MarkAshraf96]

My fault sorry, I didn't notice that they are already included, and the changes you did in the pipeline-package.js.