Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Is this project dead? #207

Open
MartinThoma opened this issue Mar 23, 2023 · 4 comments
Open

Maintenance: Is this project dead? #207

MartinThoma opened this issue Mar 23, 2023 · 4 comments

Comments

@MartinThoma
Copy link

I see a couple of indicators, that this project might be dead:

  1. Last commit is from January 2018 - that is more than 5 years ago!
  2. Broken links https://pypi.org/project/fpdf/ links via "Homepage" to a google code page
  3. Python 2.5 to 3.4 support: Python 2 can probably be dropped, but Python 3.11 should be added

I've created the github organization https://github.com/py-pdf for Python projects around PDF. While I would very much prefer it this project came back to live by itself, it might be an option for you to move the project there / give me permission to merge PRs / update the package on PyPI.

https://github.com/jazzband would be another option

@MartinThoma
Copy link
Author

There is also https://pypi.org/project/fpdf2/ (history). I'm not sure if anybody has attempted to merge fpdf2 back into fpdf.

@MartinThoma
Copy link
Author

I just saw #171

@MartinThoma
Copy link
Author

MartinThoma commented Mar 23, 2023

@reingart It would be nice to have an official note that fpdf2 is the way to go forward. I suggest to do the following:

  1. Merge MAINT: Marking the project as inactive #208
  2. Release one last patch update to PyPI so that those changes become visible
  3. Archive this repository: It's still visible, but clear to everybody that it's no longer under development.

@nemkin
Copy link

nemkin commented Sep 14, 2023

It seems like this project is no longer maintained and has been forked as fpdf2. fpdf2 uses the same import fpdf statement as this one does, which is really confusing and causes issues due to API changes between the two.

Consider for example seeing this python script:

from fpdf import FPDF

pdf = FPDF()
pdf.add_page(format=(100, 100))
content.set_fill_color(0,0,0)
content.rect(0, 0, 100, 100, 'F')
content.output('result.pdf')

Based on what you see, you'd want to run pip install fpdf in order to use the script, which succeeds. However that results in the following error, as the API has been changed in fpdf2.

$ python example.py 
Traceback (most recent call last):
  File "/home/user/example.py", line 4, in <module>
    pdf.add_page(format=(100, 100))
TypeError: add_page() got an unexpected keyword argument 'format'

Looking up the error, you can see other people are having similar issues [1, 2, 3, 4].

It seems to me that the best solution would be to have pip install fpdf install fpdf2, but that requires permission from @reingart.

If not, there should be clear distinction between the two projects, e.g. use import fpdf2, so it is clear which one of the two a Python script was based on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants