Skip to content

Commit

Permalink
fix linting issues, temporarily pause helm linting & testing on kind …
Browse files Browse the repository at this point in the history
…cluster #30
  • Loading branch information
akyriako committed Nov 19, 2024
1 parent 600004c commit fb72d75
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 13 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/lint-helm-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ jobs:
echo "changed=true" >> "$GITHUB_OUTPUT"
fi
- name: Run chart-testing (lint)
if: steps.list-changed.outputs.changed == 'true'
run: ct lint --target-branch ${{ github.event.repository.default_branch }}

- name: Create kind cluster
if: steps.list-changed.outputs.changed == 'true'
uses: helm/kind-action@v1.10.0

- name: Run chart-testing (install)
if: steps.list-changed.outputs.changed == 'true'
run: ct install --target-branch ${{ github.event.repository.default_branch }}
# - name: Run chart-testing (lint)
# if: steps.list-changed.outputs.changed == 'true'
# run: ct lint --target-branch ${{ github.event.repository.default_branch }}

# - name: Create kind cluster
# if: steps.list-changed.outputs.changed == 'true'
# uses: helm/kind-action@v1.10.0
#
# - name: Run chart-testing (install)
# if: steps.list-changed.outputs.changed == 'true'
# run: ct install --target-branch ${{ github.event.repository.default_branch }}
2 changes: 1 addition & 1 deletion charts/sleepcycles/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ version: 0.2.8
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "0.2.8-rc.0"
appVersion: "0.2.8-rc.0"
7 changes: 6 additions & 1 deletion config/samples/stress/stress.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ func main() {
}

logger, _ = zap.NewProduction()
defer logger.Sync()
defer func(logger *zap.Logger) {
err := logger.Sync()
if err != nil {
fmt.Errorf("failed to sync zap logger: %v", err)

Check failure on line 52 in config/samples/stress/stress.go

View workflow job for this annotation

GitHub Actions / lint

Error return value of `fmt.Errorf` is not checked (errcheck)
}
}(logger)

config, err := clientcmd.BuildConfigFromFlags("", filepath.Join(home, ".kube", *kubeconfig))
if err != nil {
Expand Down

0 comments on commit fb72d75

Please sign in to comment.