Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail depending on their order #62

Open
fayalalebrun opened this issue Feb 11, 2021 · 3 comments
Open

Tests fail depending on their order #62

fayalalebrun opened this issue Feb 11, 2021 · 3 comments
Assignees

Comments

@fayalalebrun
Copy link
Collaborator

On the latest revision of the code base, tests will fail around 10-20% of the time, depending on their order. It's hard to trace the reason why, since each time the tests are run, their order is different.

As an idea, it would be useful to be able to choose the order of the tests. And for this order to be printed whenever it's randomly generated.

@NULLx76
Copy link
Collaborator

NULLx76 commented Feb 11, 2021

The tests are randomized here, if you want to test a specific order you can make your own test.c file. Using seeded random, allowing to give the seed and printing the seed could be a nicer solution than what currently exists. Though feel free to implement what you deem useful.

It's worth noting that the random order was a conscious choice exactly to find more problems like this.

@fayalalebrun
Copy link
Collaborator Author

Indeed, that does sound like the best solution. I'll get started on working on adding an option to seed the generation as well as printing the seed.

@jdonszelmann
Copy link
Collaborator

We made tests randomized precisely because we wanted to find such bugs that only happen in specific situations of memory usage. Most likely cause is something in the memory managers. Luckily it's quite easy to attach the debugger to the kernel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants