feat: add initial process, thread and scheduler #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULLx76
reviewed
Mar 14, 2020
# Conflicts: # kernel/src/drivers/chipset/bcm2836/uart.c
NULLx76
requested changes
Apr 9, 2020
kernel/Makefile
Outdated
| @@ -4,7 +4,9 @@ include $(CURDIR)/../config.mk | |||
|
|
|||
| # TODO should we have "-nostdinc"? | |||
| # Flags to give to the c compiler | |||
| CFLAGS += -pipe -std=gnu99 -ffreestanding -Wall -Werror -g -O0 -mcpu=arm1176jzf-s -march=armv6zk -mfpu=vfp -fpic | |||
| CFLAGS += -pipe -std=gnu99 -ffreestanding \ | |||
| -Wall -Werror -Wno-error=unused-function -Wno-error=unused-label -Wno-error=unused-parameter -Wno-error=unused-variable -Wno-error=unused-value -Wno-error=unused-local-typedefs \ | |||
There was a problem hiding this comment.
We shouldn't ignore these errors
| push {r0} // CPSR | ||
| sub sp, #60 | ||
|
|
||
| push {r1} // push r0 |
| #define COURSE_OS_ELF_FILES_H | ||
|
|
||
| unsigned int swi_len; | ||
| unsigned char swi[34532]; |
There was a problem hiding this comment.
Where does this magic number come from
| void handle_syscall(size_t syscallnr, size_t param1, size_t param2, size_t param3, size_t param4) { | ||
| INFO("Handling syscall %i", syscallnr); | ||
|
|
||
| // switch (syscallnr) { |
There was a problem hiding this comment.
This seems heavily incomplete?
| #include <thread.h> | ||
| #include <process.h> | ||
|
|
||
| TEST_CREATE(test_process_smoke, { |
|
Could you please elaborate on "not done", what is it that does work right now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basis for a scheduler.
While it is not done, it does give a good basis for further work.
Suggestions for that work: