Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logic to check whether the user belongs to the organization which is the target keyboard #52

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Add a logic to check whether the user belongs to the organization which is the target keyboard #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions functions/src/keyboards/create-keyboard-statistics-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,27 @@ export class CreateKeyboardStatisticsCommand extends AbstractCommand<ICreateKeyb
};
}
const keyboardDefinition = keyboardDefinitionSnapshot.data()!;
if (keyboardDefinition.author_uid !== uid) {
return {
success: false,
errorCode: ERROR_KEYBOARD_DEFINITION_NOT_FOUND,
errorMessage: `The user is not an owner of the keyboard definition ${keyboardDefinitionId}.`,
};
if (keyboardDefinition.author_type === 'organization') {
const organizationId = keyboardDefinition.organization_id;
const result = await this.checkUserIsOrganizationMember(
uid,
organizationId
);
if (!result) {
return {
success: false,
errorCode: ERROR_KEYBOARD_DEFINITION_NOT_FOUND,
errorMessage: `The user is not a member of the organization ${organizationId}.`,
};
}
} else {
if (keyboardDefinition.author_uid !== uid) {
return {
success: false,
errorCode: ERROR_KEYBOARD_DEFINITION_NOT_FOUND,
errorMessage: `The user is not an owner of the keyboard definition ${keyboardDefinitionId}.`,
};
}
}
return {
success: true,
Expand Down
Loading