Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSSから@importを廃止する #844

Merged
merged 2 commits into from
Jun 9, 2024
Merged

SCSSから@importを廃止する #844

merged 2 commits into from
Jun 9, 2024

Conversation

L4Ph
Copy link
Contributor

@L4Ph L4Ph commented Jun 8, 2024

  1. sassのアップグレード
  2. sass-migratorで@useへ移行するために、_variables.scssを絶対パスでiのimportを相対パスに変更
  3. sass-migratorですべての.scssから再帰的に@importを削除
npx sass-migrator module --migrate-deps ./src/**/*.scss

yoichiro
yoichiro approved these changes Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@yoichiro yoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@L4Ph LGTM. Thanks!

@yoichiro yoichiro merged commit 69fe1f1 into remap-keys:main Jun 9, 2024
1 check passed
@L4Ph L4Ph deleted the sass-migrator branch June 9, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoichiro yoichiro yoichiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L4Ph @yoichiro