fix(element): ensure props.children is an array in createElement

remarkablegames · Jan 8, 2024 · 83ab991 · 83ab991
1 parent c5e90b4
commit 83ab991
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 0 deletions.
diff --git a/src/element/__snapshots__/create.test.ts.snap b/src/element/__snapshots__/create.test.ts.snap
@@ -80,3 +80,40 @@ exports[`creates element [Function Component] 6`] = `
   "type": [Function],
 }
 `;
+
+exports[`creates element [Function Component] 7`] = `
+{
+  "key": null,
+  "props": {
+    "children": [
+      [Function],
+      [Function],
+    ],
+  },
+  "type": [Function],
+}
+`;
+
+exports[`creates element [Function Component] 8`] = `
+{
+  "key": null,
+  "props": {
+    "children": [
+      [Function],
+    ],
+  },
+  "type": [Function],
+}
+`;
+
+exports[`creates element [Function Component] 9`] = `
+{
+  "key": null,
+  "props": {
+    "children": [
+      [Function],
+    ],
+  },
+  "type": [Function],
+}
+`;
diff --git a/src/element/create.test.ts b/src/element/create.test.ts
@@ -10,6 +10,9 @@ it.each([
   [Component, { style: { width: 100, height: 200 } }],
   [Component, { style: { width: 100, height: 200 } }, null],
   [Component, { style: { width: 100, height: 200 } }, Component],
+  [Component, {}, Component, Component],
+  [Component, { children: Component }],
+  [Component, { children: [Component] }],
 ])('creates element %p', (...args) => {
   expect(
     // eslint-disable-next-line prefer-spread

diff --git a/src/element/create.ts b/src/element/create.ts
@@ -23,6 +23,10 @@ export function createElement(
     props.children = children;
   }
 
+  if (props.children && !Array.isArray(props.children)) {
+    props.children = [props.children];
+  }
+
   return {
     type,
     props,