Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex issues in safari 16 (iOS) and below #69

Closed
4 tasks done
KenjiEmura opened this issue Oct 1, 2024 · 4 comments
Closed
4 tasks done

Regex issues in safari 16 (iOS) and below #69

KenjiEmura opened this issue Oct 1, 2024 · 4 comments
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@KenjiEmura
Copy link

Initial checklist

Affected packages and versions

4.0.0

Link to runnable example

No response

Steps to reproduce

I'm using remark-gfm in a Next.js project and the library is making the project crash on devices running iOS 16 and below. As far as my research went, it seems to be something related to the lookbehind or lookahead methods for regex which are supported from safari 16.4 and above.

I would like to kindly ask if you could also include support for safari 15 and above or if you can show me a workaround to solve this issue. Thanks a lot.

Expected behavior

The package should have some kind of fallback for regex methods that are not supported in the runtime.

Actual behavior

The unhandled missing methods make the application crash.

Runtime

No response

Package manager

pnpm

OS

Other (please specify in steps to reproduce)

Build and bundle tools

Next.js

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 1, 2024
@wooorm
Copy link
Member

wooorm commented Oct 1, 2024

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024

This comment has been minimized.

@wooorm wooorm added the 👯 no/duplicate Déjà vu label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 1, 2024
@nguyenchauhuyen

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

3 participants