Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server-runtime): deprecate SerializeFrom type #10173

Merged
merged 1 commit into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-zebras-stare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/server-runtime": minor
---

Deprecate `SerializeFrom` in favor of generics because it will be removed in React Router v7
5 changes: 5 additions & 0 deletions packages/remix-server-runtime/serialize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ type SingleFetchEnabled =
*
* For example:
* `type LoaderData = SerializeFrom<typeof loader>`
*
* @deprecated SerializeFrom is deprecated and will be removed in React Router
* v7. Please use the generics on `useLoaderData`/etc. instead of manually
* deserializing in Remix v2. You can convert to the generated types once you
* migrate to React Router v7.
*/
export type SerializeFrom<T> =
SingleFetchEnabled extends true ? SingleFetch_SerializeFrom<T> :
Expand Down