Fixed key error issue in file-disks/disk.py #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ater than the computed block of addresses it throws a key error while seeking and the seeking action wouldn’t stop. Fixed this issue by exiting the program if the requested block is less than the maximum block allowed in InitBlockLayout.
There was a problem hiding this comment.
This is indeed a bug, or, at least, something to handle more gracefully (one could argue that throwing an uncaught exception is fine...). However, this is not the right place to put checking code. I think the best place might be in MakeRequests(), which is called for normal requests as well as "late" ones, and handles both forms of user-passed in addresses...
|
@remzi-arpacidusseau I wasn't able to get what are late requests. I tried running the following command but it throws key error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the requested list of block addresses contains a block address greater than the computed block of addresses it throws a key error while seeking and the seeking action wouldn’t stop. Fixed this issue in file-disks/disk.py by exiting the program if the requested block is less than the maximum block allowed in InitBlockLayout.
ex:
./disk.py -a 10,20,40 -G.
(without the changes the above command would throw key error 40)
After the changes the program would exit with the following message
Error: The requested block address 40 is greater than the maximum block 35 available.