Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funds-manager: custody-client: Add endpoint to withdraw to cold storage #21

Merged
merged 1 commit into from
Jul 31, 2024
Merged

funds-manager: custody-client: Add endpoint to withdraw to cold storage #21

merged 1 commit into from
Jul 31, 2024

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Jul 30, 2024 •
edited
Loading

Purpose

This PR implements an endpoint that lets us withdraw from hot wallets into Fireblocks vaults. The endpoint takes the following steps:

  1. Lookup the hot wallet in our database, find its vault
  2. Lookup the vault deposit address that the specific ERC20 targets
  3. Execute an ERC20 transfer to the vault address

Testing

  • Tested the endpoint locally by transferring a dummy erc20 into Fireblocks

@joeykraut joeykraut force-pushed the joey/hot-wallet-to-fireblocks branch from e3f4173 to 25ab5b4 Compare July 30, 2024 20:31
@joeykraut joeykraut changed the title Joey/hot wallet to fireblocks funds-manager: custody-client: Add endpoint to withdraw to cold storage Jul 30, 2024
@joeykraut joeykraut force-pushed the joey/hot-wallet-to-fireblocks branch from 25ab5b4 to 0ce3163 Compare July 30, 2024 20:39
@joeykraut joeykraut requested a review from akirillo July 30, 2024 20:47
@joeykraut joeykraut marked this pull request as ready for review July 30, 2024 20:47
@joeykraut joeykraut merged commit e38a479 into main Jul 31, 2024
4 checks passed
@joeykraut joeykraut deleted the joey/hot-wallet-to-fireblocks branch July 31, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirillo akirillo akirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykraut @akirillo