Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funds-manager: execution-client: Add quote execution helpers #33

Merged
merged 1 commit into from
Aug 12, 2024
Merged

funds-manager: execution-client: Add quote execution helpers #33

merged 1 commit into from
Aug 12, 2024

Conversation

joeykraut
Copy link
Member

@joeykraut joeykraut commented Aug 8, 2024 •
edited
Loading

Purpose

This PR sets up the execution flow for the ExecutionClient which involves:

  1. Approving an ERC20 allowance for the 0x exchange proxy
  2. Sending the transaction detailed by the quote received

Testing

  • Tested buying $GMX with $USDC on arbitrum using my personal wallet

@joeykraut joeykraut force-pushed the joey/execute-transfer branch 2 times, most recently from 7782935 to 89107cb Compare August 9, 2024 00:01
@joeykraut joeykraut marked this pull request as ready for review August 9, 2024 00:03
@joeykraut joeykraut requested a review from akirillo August 9, 2024 00:03
Base automatically changed from joey/fetch-matcha-quote to main August 12, 2024 19:57
@joeykraut joeykraut merged commit 90bc535 into main Aug 12, 2024
4 checks passed
@joeykraut joeykraut deleted the joey/execute-transfer branch August 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirillo akirillo akirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykraut @akirillo