Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funds-manager: Refill all gas wallets, not just active #37

Merged
merged 1 commit into from
Aug 24, 2024
Merged

funds-manager: Refill all gas wallets, not just active #37

merged 1 commit into from
Aug 24, 2024

Conversation

joeykraut
Copy link
Member

Purpose

This PR makes a few miscellaneous changes to the funds manager:

  • Adds logging for transitions in gas wallet states
  • Refills all gas wallets at a time, as opposed to just active ones. This adds robustness in the case of an incorrectly expired wallet and costs us no more -- unused wallets will be full anyways.
  • Changes the logic for finding an asset id by its erc20 mint to be case insensitive

@joeykraut joeykraut marked this pull request as ready for review August 24, 2024 00:17
@joeykraut joeykraut merged commit e8d6839 into main Aug 24, 2024
1 of 3 checks passed
@joeykraut joeykraut deleted the joey/funds-manager-nonces branch August 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirillo akirillo akirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeykraut @akirillo