Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

funds-manager: api: types: quoters: add estimated_gas field to ExecutionQuote #40

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

akirillo
Copy link
Contributor

This PR adds the estimatedGas field to the subset of Matcha /swap/v1/quote response fields captured by the ExecutionQuote struct.

This is purely for convenience, we would like to be able to view the all-in estimated gas cost when considering an execution.

@akirillo akirillo added the enhancement New feature or request label Aug 28, 2024
@akirillo akirillo self-assigned this Aug 28, 2024
@akirillo akirillo merged commit c7ece16 into main Aug 30, 2024
4 checks passed
@akirillo akirillo deleted the andrew/execution-quote-estimated-gas branch August 30, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants