Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

price-reporter: ws-server: Retry connection on send failure #43

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

joeykraut
Copy link
Member

Purpose

This PR makes two changes:

  1. We refactor the price_stream_task into a retry wrapper that calls manage_connection. This captures a broader set of errors that may be retried, including error sending a keepalive on a closed connection. Looking at our logs, this makes up the majority of server failures
  2. Adds logging for the case in which re-establishing a connection fails

Testing

  • Ran the price reporter locally and simulated a failure, verified that the recovery logic worked as expected

@joeykraut joeykraut marked this pull request as ready for review September 6, 2024 18:33
Copy link
Contributor

@akirillo akirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@joeykraut joeykraut merged commit edcc6a6 into main Sep 6, 2024
2 of 4 checks passed
@joeykraut joeykraut deleted the joey/retry-send-failures branch September 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants