Skip to content

Commit

Permalink
Replace deprecated package
Browse files Browse the repository at this point in the history
  • Loading branch information
leo108 committed May 20, 2023
1 parent 046c682 commit 0d78366
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 9 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ jobs:
# vendor/bin/psalm

- name: Run tests
env:
KUBERNETES_VERSION: ${{ matrix.kubernetes }}
run: |
vendor/bin/phpunit --coverage-text --coverage-clover=coverage.xml
Expand Down
5 changes: 3 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@
}
],
"require": {
"ext-json": "*",
"composer/semver": "^2.0|^3.0",
"guzzlehttp/guzzle": "^6.5|^7.0",
"illuminate/macroable": "^9.35|^10.1",
"illuminate/support": "^9.35|^10.1",
"ratchet/pawl": "^0.4.1",
"symfony/process": "^5.4|^6.0",
"vierbergenlars/php-semver": "^2.1|^3.0"
"symfony/process": "^5.4|^6.0"
},
"suggest": {
"ext-yaml": "YAML extension is used to read or generate YAML from PHP K8s internal classes."
Expand Down
19 changes: 12 additions & 7 deletions src/Traits/Cluster/ChecksClusterVersion.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

namespace RenokiCo\PhpK8s\Traits\Cluster;

use Composer\Semver\Comparator;
use GuzzleHttp\Exception\ClientException;
use RenokiCo\PhpK8s\Exceptions\KubernetesAPIException;
use vierbergenlars\SemVer\version as Semver;

trait ChecksClusterVersion
{
/**
* The Kubernetes cluster version.
*
* @var \vierbergenlars\SemVer\version|null
* @var string|null
*/
protected $kubernetesVersion;

Expand Down Expand Up @@ -44,7 +44,7 @@ protected function loadClusterVersion(): void

$json = @json_decode($response->getBody(), true);

$this->kubernetesVersion = new Semver($json['gitVersion']);
$this->kubernetesVersion = self::trimVersion($json['gitVersion']);
}

/**
Expand All @@ -58,8 +58,8 @@ public function newerThan(string $kubernetesVersion): bool
{
$this->loadClusterVersion();

return Semver::gte(
$this->kubernetesVersion, $kubernetesVersion
return Comparator::greaterThanOrEqualTo(
$this->kubernetesVersion, self::trimVersion($kubernetesVersion)
);
}

Expand All @@ -74,8 +74,13 @@ public function olderThan(string $kubernetesVersion): bool
{
$this->loadClusterVersion();

return Semver::lt(
$this->kubernetesVersion, $kubernetesVersion
return Comparator::lessThan(
$this->kubernetesVersion, self::trimVersion($kubernetesVersion)
);
}

private static function trimVersion(string $version): string
{
return preg_replace('/^v/', '', $version);
}
}
39 changes: 39 additions & 0 deletions tests/CheckClusterVersionTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php

namespace RenokiCo\PhpK8s\Test;

class CheckClusterVersionTest extends TestCase
{
protected $clusterVersion;

public function setUp(): void
{
parent::setUp();
$this->clusterVersion = $_SERVER['KUBERNETES_VERSION'];
}

public function test_newer_than()
{
$this->assertTrue($this->cluster->newerThan($this->clusterVersion));
$this->assertTrue($this->cluster->newerThan('v'.$this->clusterVersion));
$this->assertTrue($this->cluster->newerThan($this->change_version(1, 0)));
$this->assertFalse($this->cluster->newerThan($this->change_version(2, 99)));
}

public function test_old_than()
{
$this->assertFalse($this->cluster->olderThan($this->clusterVersion));
$this->assertFalse($this->cluster->olderThan('v'.$this->clusterVersion));
$this->assertTrue($this->cluster->olderThan($this->change_version(1, 99)));
$this->assertTrue($this->cluster->olderThan($this->change_version(0, 2)));
$this->assertFalse($this->cluster->olderThan($this->change_version(1, 0)));
}

protected function change_version(int $position, int $version): string
{
$parts = explode('.', $this->clusterVersion);
$parts[$position] = $version;

return implode('.', $parts);
}
}

0 comments on commit 0d78366

Please sign in to comment.