-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated "colorama" package to latest #192
base: master
Are you sure you want to change the base?
Conversation
@renskiy hello, can you look at this PR and if everything is ok, please merge it |
@barbossa looks good for me. But can you explain why you need newer version of |
In my project I have unresolved dependency for "colorama" that broke updating New version of |
@@ -4,8 +4,6 @@ sudo: false | |||
|
|||
python: | |||
- "2.7" | |||
- "3.4" | |||
- "3.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version of Colorama does support Python 3.5. Are you sure about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renskiy you're right, we should support Python 3.5.
I've made an additional commit and returned Python 3.5 to travis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, but I've forgot do the same with fabricio doc. Need one more commit 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renskiy I think you should make squash commits before merging and combine my 7 commits into 1.
Github interface should support squashing before merging.
changelog.rst
Outdated
@@ -1,6 +1,12 @@ | |||
Changelog | |||
========= | |||
|
|||
Release 0.5.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compatibility-breaking changes should increase major version too. I think it will 0.6
after all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renskiy done.
@renskiy hey, do you plan merge this MR? 🙂 |
@barbossa yes, next week |
@barbossa hi, sorry for delay. But I actually have not decided to make new version yet. But your PR will be in this version when it will be released. Speaking about dependencies and dependency conflicts I think you should not mix Fabricio environment (AKA deploy environment) and your project code environment. There are many version conflicts will be if such mixing take place. To solve your issue you can install Fabricio in another environment. Installation process will add
|
@renskiy hey. Don't worry about late response, everything is ok 🙂 I I've figure out my issue, I use fork of fabricio with fixed dependency conflicts. I can wait while you do release. |
Latest version of colorama is 0.4.3 https://pypi.org/project/colorama/.