Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate NSFetchRequest without executing it #380

Open
halmueller opened this issue Dec 5, 2018 · 3 comments
Open

generate NSFetchRequest without executing it #380

halmueller opened this issue Dec 5, 2018 · 3 comments

Comments

@halmueller
Copy link

halmueller commented Dec 5, 2018

Feature Request

I'd like to see the template create +fetch<Foo>Request methods that return an NSFetchRequest so that I can modify it, in code, before executing it.

Additional Information

I have a modified template pair that does this. Are you interested in a PR? Should I wrap it in a template variable (to optionally disable/enable it)?

@rentzsch
Copy link
Owner

rentzsch commented Dec 6, 2018

Hey Hal,

Good to hear from you again.

In general, I think that's a fine idea.

How would -fetchRequestFromTemplateWithName: vs -fetchRequestFromTemplateWithName:substitutionVariables: be handled?

Would the generated fetch request wrapper machine code also use these accessors?

This may be easier to answer in an actual Pull Request than English, so please send me whatever is easiest for you.

@halmueller
Copy link
Author

Let me make sure that is handled appropriately. And then I'll do a PR against the swift42 branch.

@atomicbird
Copy link
Collaborator

@halmueller That sounds promising. The swift42 branch has been delayed due to work concerns but I have some days off coming up where I'm hoping to wrap things up. If you have a PR soon it can go into the branch, otherwise the branch will be merged and we can get it into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants