Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): changing to invoke providers workflow as a job #473

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR changes invoking the providers test sub-workflow as a job instead of as a step, to fix the issue where the local sub-workflow files are not supported as a step.

Resolves #464

How Has This Been Tested?

Invoking the sub-workflow as a job is tested on the forked repository.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother self-assigned this Jan 16, 2024
@geekbrother geekbrother changed the title fix(ci): changing to call providers workflow as a job fix(ci): changing to invoke providers workflow as a job Jan 16, 2024
outputs:
providers: ${{ steps.set-matrix.outputs.providers }}
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating to the latest version.

@@ -70,15 +71,16 @@ jobs:
providers-test:
name: "Run provider tests"
needs: providers-list
runs-on: ubuntu-latest
runs-on:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing the run group to be consistent across tests.

@geekbrother geekbrother marked this pull request as ready for review January 16, 2024 10:59
@geekbrother geekbrother requested a review from xav as a code owner January 16, 2024 10:59
@geekbrother geekbrother merged commit eaaf79e into master Jan 16, 2024
11 of 13 checks passed
@geekbrother geekbrother deleted the fix/change_providers_to_be_step branch January 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ci): run providers tests only when the providers code is changed
2 participants