Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(o11y): adding HTTP 40[1-3] alerts for providers #835

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

geekbrother
Copy link
Contributor

Description

This PR adds an alert in case the provider responds with HTTP 40[1-3] errors.
We should track these responses since they reflect paid providers' payment or plan issues and we should take action on this.
Only 40[1-3] were included, because of:

  • HTTP 400 Bad Request - reflecting the client request error,
  • HTTP 404 Not Found - some providers (like 1Inch) use this response as a client error request (requested token not found, etc).

How Has This Been Tested?

Not tested.

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@geekbrother geekbrother merged commit 9823700 into master Nov 19, 2024
14 checks passed
@geekbrother geekbrother deleted the feat/add_4xx_alerts branch November 19, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants