Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Entry Tags #202

Open
wants to merge 34 commits into
base: v3
Choose a base branch
from
Open

Add Entry Tags #202

wants to merge 34 commits into from

Conversation

selectdev
Copy link
Contributor

This will add Entry Tags into Repldex v3!

@selectdev selectdev added the enhancement New feature or request label Mar 19, 2022
@selectdev selectdev requested a review from mat-1 March 19, 2022 05:53
@selectdev selectdev linked an issue Mar 19, 2022 that may be closed by this pull request
@selectdev
Copy link
Contributor Author

I'm going to work on this tommorow with @JetStream0 as i did the most that i can do myself with the database. On Sunday, i will work on the Edit Entry design, so people can add Tags into their Entry

@stjet
Copy link
Collaborator

stjet commented Mar 19, 2022

We will need to add a search bar with tag search support, and a way for admins to add tags. We might want to consider adding tag search to the discord bot.

@selectdev selectdev marked this pull request as ready for review March 22, 2022 01:46
@selectdev
Copy link
Contributor Author

This is still a work in progress, but is ready for some feedback. Please review our code and test it so we can fix any issues that you may detect!

@selectdev
Copy link
Contributor Author

We will need to add a search bar with tag search support, and a way for admins to add tags. We might want to consider adding tag search to the discord bot.

shit, completely forgot about needing admins to add tags. imma need your help, like a lot since idk shit about mongoose on typescript

@selectdev
Copy link
Contributor Author

We will need to add a search bar with tag search support, and a way for admins to add tags. We might want to consider adding tag search to the discord bot.

Will add tag search into discord bot sometime, maybe we could add it as a separate field but make it optional

@stjet
Copy link
Collaborator

stjet commented Mar 24, 2022

I believe we are ready for review. Everything should be done and probably working. @mat-1

@selectdev selectdev marked this pull request as draft March 26, 2022 03:32
selectdev and others added 4 commits June 18, 2022 23:22
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
@selectdev selectdev removed the Ready for Review This issue/pr is ready to be reviewed. label Jun 19, 2022
@selectdev
Copy link
Contributor Author

Removed "Ready for Review" label as this cannot be reviewed due to it failing the checks. Please resolve all the conversations as well as the conflicts.

@selectdev selectdev requested a review from mat-1 June 19, 2022 20:56
@selectdev selectdev dismissed mat-1’s stale review June 19, 2022 20:57

Fixed some stuff, need better review now

@selectdev selectdev added the Ready for Review This issue/pr is ready to be reviewed. label Jun 19, 2022
@selectdev
Copy link
Contributor Author

This pr is now ready for review, and the "Ready for Review" label has been added. I have also removed @mat-1's review as well as conversations/review comments. Please make sure this pr is reviewed closely and ensure that it won't make any breaking changes toward production.

@selectdev
Copy link
Contributor Author

This is still awaiting review from @mat-1

@selectdev selectdev removed the Ready for Review This issue/pr is ready to be reviewed. label Jul 7, 2022
selectdev and others added 4 commits July 6, 2022 20:57
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
Co-authored-by: mat <27899617+mat-1@users.noreply.github.com>
@stjet
Copy link
Collaborator

stjet commented Nov 13, 2022

@Codemonkey51 Please review! Tested and working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Experimental This issue/pr is experimental and should be tested very carefully to ensure any possible breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Entry Tags
3 participants