-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): address melange's latest change #1560
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGAntunes
changed the title
chore(ci): pin melange version
chore(ci): shorten the version string to address melange's latest change
Nov 29, 2024
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
JGAntunes
commented
Nov 29, 2024
Comment on lines
-12
to
-14
"github.com/replicatedhq/embedded-cluster/pkg/runtimeconfig" | ||
"github.com/replicatedhq/embedded-cluster/pkg/versions" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
laverya
previously approved these changes
Nov 29, 2024
JGAntunes
changed the title
chore(ci): shorten the version string to address melange's latest change
chore(ci): address melange's latest change
Nov 29, 2024
laverya
approved these changes
Nov 29, 2024
This was referenced Nov 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For more context see - https://replicated.slack.com/archives/C0499EGNPNY/p1732733447572059
With the latest
melange
changes through - chainguard-dev/melange#1622 - our CI pipelines started failing with:The way the name header is built can be seen here:
The change introduced was enough to trip the USTAR 100 byte limit.
To prevent this we're reducing the package name + version we use in the
melange.yaml
for the operator:embedded-cluster/operator/deploy/melange.tmpl.yaml
Lines 2 to 3 in fa700cd
This is a quick workaround. We might wanna further reduce the version/name (does it even matter the version we use for the melange package here?) or even have a chat with chainguard to understand what's the best way to overcome this and avoid being hit by this in the near future.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?