Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): address melange's latest change #1560

Merged
merged 9 commits into from
Nov 29, 2024
Merged

Conversation

JGAntunes
Copy link
Member

@JGAntunes JGAntunes commented Nov 29, 2024

What this PR does / why we need it:

For more context see - https://replicated.slack.com/archives/C0499EGNPNY/p1732733447572059

With the latest melange changes through - chainguard-dev/melange#1622 - our CI pipelines started failing with:

INFO error during command execution: failed to build image components: building layers: building layers: for arch "amd64": installing apk packages: installing packages: installing embedded-cluster-operator (ver:1.19.0+k8s-1.30-59-gf845a740-upgrade-r0 arch:x86_64): unable to update scripts.tar for pkg embedded-cluster-operator: unable to write scripts header for embedded-cluster-operator-1.19.0+k8s-1.30-59-gf845a740-upgrade-r0.Q17P2Pb+0fdYeQTtIVeyqFDm8XEYE=.melange.yaml: archive/tar: cannot encode header: Format specifies USTAR; and USTAR cannot encode Name="embedded-cluster-operator-1.19.0+k8s-1.30-59-gf845a740-upgrade-r0.Q17P2Pb+0fdYeQTtIVeyqFDm8XEYE=.melange.yaml"

The way the name header is built can be seen here:

The change introduced was enough to trip the USTAR 100 byte limit.

To prevent this we're reducing the package name + version we use in the melange.yaml for the operator:

This is a quick workaround. We might wanna further reduce the version/name (does it even matter the version we use for the melange package here?) or even have a chat with chainguard to understand what's the best way to overcome this and avoid being hit by this in the near future.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

@JGAntunes JGAntunes changed the title chore(ci): pin melange version chore(ci): shorten the version string to address melange's latest change Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-7ffa2b2" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-7ffa2b2?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

Comment on lines -12 to -14
"github.com/replicatedhq/embedded-cluster/pkg/runtimeconfig"
"github.com/replicatedhq/embedded-cluster/pkg/versions"

Copy link
Member Author

@JGAntunes JGAntunes Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the current compiler issue we're facing. Supersedes #1559 and #1558

@JGAntunes JGAntunes self-assigned this Nov 29, 2024
laverya
laverya previously approved these changes Nov 29, 2024
@JGAntunes JGAntunes changed the title chore(ci): shorten the version string to address melange's latest change chore(ci): address melange's latest change Nov 29, 2024
@laverya laverya merged commit 2d84625 into main Nov 29, 2024
65 checks passed
@laverya laverya deleted the chore/pin-melange-version branch November 29, 2024 22:02
This was referenced Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants