Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin console): save bundle of last run preflight in Admin Console #4887

Merged

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Sep 13, 2024

What this PR does / why we need it:

  • Save bundle in /tmp/last-preflight-result directory of last run preflight in Admin Console to be used by users whenever they want to troubleshoot failing preflights during development
  • Add collector to store the directory in support bundles

Which issue(s) this PR fixes:

Fixes: sc-111576

Does this PR require a test?

NONE

Does this PR require a release note?

Store collected bundle data in /tmp/last-preflight-result of last run preflight in Admin Console

Does this PR require documentation?

NONE

- Save preflight bundle in /tmp/last-preflight-result directory
- Add collector to store the directory in support bundles

Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh added the type::feature New feature or request label Sep 13, 2024
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
…be-saved' of github.com:replicatedhq/kots into evansmungai/sc-111576/preflight-collect-results-should-be-saved
Signed-off-by: Evans Mungai <evans@replicated.com>
emosbaugh
emosbaugh previously approved these changes Sep 13, 2024
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
Signed-off-by: Evans Mungai <evans@replicated.com>
@adamancini
Copy link
Member

adamancini commented Sep 13, 2024

@banjoh just watched the asciinema, does the feature write the tarball only if you click s to save or does it just happen always?

I suppose the followup is: does it save the tarball if you also pass non-interactive flag?

@banjoh
Copy link
Member Author

banjoh commented Sep 13, 2024

@banjoh just watched the asciinema, does the feature write the tarball only if you click s to save or does it just happen always?

I suppose the followup is: does it save the tarball if you also pass non-interactive flag?

Responses in replicatedhq/troubleshoot#1612 (comment)

Signed-off-by: Evans Mungai <evans@replicated.com>
emosbaugh
emosbaugh previously approved these changes Sep 17, 2024
Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh enabled auto-merge (squash) September 19, 2024 15:09
Signed-off-by: Evans Mungai <evans@replicated.com>
@banjoh banjoh merged commit 99b0561 into main Sep 23, 2024
117 checks passed
@banjoh banjoh deleted the evansmungai/sc-111576/preflight-collect-results-should-be-saved branch September 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants