Allow specifying custom Certificate Authority as a ConfigMap name #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
force-pushed
the
divolgin/sc-98357/use-a-custom-certificate-authority-with-replicated
branch
from
1d068d4
to
ef52e5c
Compare
divolgin
force-pushed
the
divolgin/sc-98357/use-a-custom-certificate-authority-with-replicated
branch
3 times, most recently
from
e7adef4
to
8f57e93
Compare
sgalsaleh
reviewed
Sep 20, 2024
ajp-io
reviewed
Sep 20, 2024
divolgin
force-pushed
the
divolgin/sc-98357/use-a-custom-certificate-authority-with-replicated
branch
from
8f57e93
to
54e5ff9
Compare
divolgin
force-pushed
the
divolgin/sc-98357/use-a-custom-certificate-authority-with-replicated
branch
from
54e5ff9
to
036dce2
Compare
pandemicsyn
approved these changes
Sep 20, 2024
divolgin
deleted the
divolgin/sc-98357/use-a-custom-certificate-authority-with-replicated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds support for specifying additional Certificate Authorities that can be used for adding private CAs when deploying behind a proxy.
Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/98357/use-a-custom-certificate-authority-with-replicated-sdk
Special notes for your reviewer:
Relevant docs PR: replicatedhq/replicated-docs#2667
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?