Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: comment out weave IP allocation analyser #71

Merged

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Jul 6, 2023

Comment out Weave IP Allocation analyser that is leading to false positives. Have it reinstated when working on #43

@banjoh banjoh self-assigned this Jul 6, 2023
@@ -3,8 +3,11 @@ kind: SupportBundle
metadata:
name: default
spec:
uri: https://raw.githubusercontent.com/replicatedhq/troubleshoot-specs/main/in-cluster/default.yaml
uri: https://raw.githubusercontent.com/replicatedhq/troubleshoot-specs/main/host/default.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still be in-cluster right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has changes from another branch :(

git-foo failing me :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@banjoh banjoh force-pushed the em/comment-out-weave-analyser branch from 026a239 to dfb0a5f Compare July 6, 2023 13:28
@diamonwiggins diamonwiggins merged commit c555ca5 into replicatedhq:main Jul 6, 2023
2 checks passed
@banjoh banjoh deleted the em/comment-out-weave-analyser branch July 7, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants