Add healthcheck function to avoid breaking tests #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonathan-Carvalheiro
force-pushed
the
feat/add-health-check-to-avoid-breaking-tests
branch
2 times, most recently
from
8c6ac9c
to
3d74cc0
Compare
Jonathan-Carvalheiro
force-pushed
the
feat/add-health-check-to-avoid-breaking-tests
branch
from
3d74cc0
to
8ccf666
Compare
AmsterGet
requested changes
Oct 31, 2022
| onRunStart() { | ||
| async onRunStart() { | ||
| try { | ||
| await healthCheck(this.client); |
There was a problem hiding this comment.
I guess that for one test run it will be enough to check connection once and write the connection status to the class property to check it inside of other methods.
In this case, even when the RP goes up during the test run, the reporter will not send events to a non-existent run.
There was a problem hiding this comment.
Yes, but the problem I found on testing that approach was, when RP is unavailable during the run, it failed the test suite even if the tests passed. So I choose to add that verification in all methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent fails the JEST tests when RP is down, unreachable, or using the wrong/empty token. Added a health check to verify the connection first.