Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing implementation for logLaunchLink option #114

Closed
barking-timber opened this issue Jul 25, 2023 · 8 comments · Fixed by #118
Closed

Missing implementation for logLaunchLink option #114

barking-timber opened this issue Jul 25, 2023 · 8 comments · Fixed by #118
Milestone

Comments

@barking-timber
Copy link

Looks like it only exists in the README. Wondering how difficult it is to implement this? I have seen it in the agent-js-jest, unsure if it'd be more lift & shift to this project?

@AmsterGet
Copy link
Member

Hello @barking-timber !
It accidentally got into the readme before the official publication.
The implementation is quite simple, so we plan to release it in the next release, along with a few important fixes.

@barking-timber
Copy link
Author

Oh, that's fab! Great job everyone, I'll keep an eye on the new release!

@AmsterGet AmsterGet modified the milestones: 5.2.2, 5.2.0 Aug 6, 2023
@AmsterGet AmsterGet modified the milestones: 5.2.0, 5.1.3 Aug 29, 2023
@AmsterGet AmsterGet linked a pull request Sep 7, 2023 that will close this issue
@AmsterGet
Copy link
Member

Hi @barking-timber !
Please check the version 5.1.3.

@barking-timber
Copy link
Author

barking-timber commented Sep 15, 2023

Cool, thanks!

So does it mean that with the launch UUID I can go create links like this?

<rpInstance>/ui/<projectName>/launches/all/<launchUuid>

Seems to be working, just don't want to miss anything obvious, more alike to the previously mentioned logLaunchLink which seems to be removed for now.

@AmsterGet
Copy link
Member

@barking-timber Yeah, you're right.

@barking-timber
Copy link
Author

Cool, do you have any plans to get logLaunchLink implemented later? It's to navigate to the test reports in RP from the CI build.

@AmsterGet
Copy link
Member

Hi @barking-timber !
We've published a version 5.1.5 that logs the link to RP launch by default.
Please refer this issue for details.

@barking-timber
Copy link
Author

Ah thanks, great. I started using it a few versions back actually, but it's great to see you got it now switched by default. This link helped us enormously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants