Release 5.1.3 #118
Merged
Release 5.1.3 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update README.md * Update README.md
* EPMRPP-8485 || Test-is-finished-when-test-exceed-timeout
* EPMRPP-84855 || Adjust onTestEnd logic
We need to remove result.status === timedOut because in case we have
expect().toPass({timeout:5_000}) and global timeout set to 20_000
status !== timedOut.
.toPass retries expect until it pass or timer exceeds. If timer exceeds
test has result === failed, but playwright itself doesn't invoke onStepEnd
method.
* EPMRPP-84855 || Code review fixes - 1
* EPMRPP-84855 || Add unit tests
Bam6ycha
approved these changes
Sep 7, 2023
|
Everything looks good to me! @AmsterGet do you have something to add to this PR? If doesn't, I will merge it. |
Actually no, go ahead! |
This was
linked to
issues
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch - http://dev.epmrpp.reportportal.io/ui/#bam6ycha/launches/all/103176