-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.10.0 #43
Release 5.10.0 #43
Conversation
EPMRPP-66951 [UI + WS] As a Admin, I can configure (CRU) a fields for issue posting to Jira Cloud on global settings
Merge master to develop
* EPMRPP-68947 || Introduce common plugin commands without existed integration * EPMRPP-68947 || Rename plugin commands * EPMRPP-68947 || Refactor interfaces * EPMRPP-68947 || Refactor interfaces * EPMRPP-68947 || Refactor interfaces * EPMRPP-68947 || Add common commands field
…nto develop � Conflicts: � gradle.properties
… event (#41) * EPMRPP-75477 || Added a new launch event for plugins Rename launch finished event Add launch deletion plugin event Update dao version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
reviewdog
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|16 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|16 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|17 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|17 col 9| 'method def rcurly' has incorrect indentation level 8, expected level should be 2.
@@ -0,0 +1,18 @@ | |||
package com.epam.reportportal.extension.event; | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary javadoc is missing.
*/ | ||
public class LaunchDeletedPluginEvent extends LaunchEvent<Long> { | ||
|
||
private final Long projectId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
*/ | ||
public class LaunchDeletedPluginEvent extends LaunchEvent<Long> { | ||
|
||
private final Long projectId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'member def modifier' has incorrect indentation level 8, expected level should be 2.
|
||
private final Long projectId; | ||
|
||
public LaunchDeletedPluginEvent(Long source, Long projectId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
|
||
private final Long projectId; | ||
|
||
public LaunchDeletedPluginEvent(Long source, Long projectId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'ctor def modifier' has incorrect indentation level 8, expected level should be 2.
|
||
public LaunchFinishedPluginEvent(Long source, Long projectId) { | ||
super(source); | ||
this.projectId = projectId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'ctor def' child has incorrect indentation level 16, expected level should be 4.
public LaunchFinishedPluginEvent(Long source, Long projectId) { | ||
super(source); | ||
this.projectId = projectId; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
public LaunchFinishedPluginEvent(Long source, Long projectId) { | ||
super(source); | ||
this.projectId = projectId; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'ctor def rcurly' has incorrect indentation level 8, expected level should be 2.
this.projectId = projectId; | ||
} | ||
|
||
public Long getProjectId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains a tab character.
this.projectId = projectId; | ||
} | ||
|
||
public Long getProjectId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'method def modifier' has incorrect indentation level 8, expected level should be 2.
No description provided.