Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.10.0 #43

Merged
merged 15 commits into from
Aug 28, 2023
Merged

Release 5.10.0 #43

merged 15 commits into from
Aug 28, 2023

Conversation

IvanKustau
Copy link
Contributor

No description provided.

pbortnik and others added 15 commits October 21, 2021 13:36
EPMRPP-66951 [UI + WS] As a Admin, I can configure (CRU) a fields for issue posting to Jira Cloud on global settings
* EPMRPP-68947 || Introduce common plugin commands without existed integration

* EPMRPP-68947 || Rename plugin commands

* EPMRPP-68947 || Refactor interfaces

* EPMRPP-68947 || Refactor interfaces

* EPMRPP-68947 || Refactor interfaces

* EPMRPP-68947 || Add common commands field
…nto develop

� Conflicts:
�	gradle.properties
… event (#41)

* EPMRPP-75477 || 
Added a new launch event for plugins
Rename launch finished event
Add launch deletion plugin event
Update dao version
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

reviewdog

src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|16 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|16 col 17| 'method def' child has incorrect indentation level 16, expected level should be 4.
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|17 col 1| Line contains a tab character.
src/main/java/com/epam/reportportal/extension/event/LaunchFinishedPluginEvent.java|17 col 9| 'method def rcurly' has incorrect indentation level 8, expected level should be 2.

@@ -0,0 +1,18 @@
package com.epam.reportportal.extension.event;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck> reported by reviewdog 🐶
Summary javadoc is missing.

*/
public class LaunchDeletedPluginEvent extends LaunchEvent<Long> {

private final Long projectId;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

*/
public class LaunchDeletedPluginEvent extends LaunchEvent<Long> {

private final Long projectId;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 8, expected level should be 2.


private final Long projectId;

public LaunchDeletedPluginEvent(Long source, Long projectId) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.


private final Long projectId;

public LaunchDeletedPluginEvent(Long source, Long projectId) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 8, expected level should be 2.


public LaunchFinishedPluginEvent(Long source, Long projectId) {
super(source);
this.projectId = projectId;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 16, expected level should be 4.

public LaunchFinishedPluginEvent(Long source, Long projectId) {
super(source);
this.projectId = projectId;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

public LaunchFinishedPluginEvent(Long source, Long projectId) {
super(source);
this.projectId = projectId;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 8, expected level should be 2.

this.projectId = projectId;
}

public Long getProjectId() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.whitespace.FileTabCharacterCheck> reported by reviewdog 🐶
Line contains a tab character.

this.projectId = projectId;
}

public Long getProjectId() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [reviewdog] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 8, expected level should be 2.

@IvanKustau IvanKustau merged commit d5b9eea into master Aug 28, 2023
8 checks passed
@IvanKustau IvanKustau deleted the rc/5.10.0 branch August 30, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants