From 96d901b7277a68f47e565de34ecc66762ea14aee Mon Sep 17 00:00:00 2001 From: maria-hambardzumian Date: Fri, 20 Sep 2024 13:16:09 +0400 Subject: [PATCH] EPMRPP-92434 || sonar fix --- .../emptyUniqueErrors/emptyUniqueErrors.jsx | 115 +++++++++--------- 1 file changed, 55 insertions(+), 60 deletions(-) diff --git a/app/src/pages/inside/uniqueErrorsPage/emptyUniqueErrors/emptyUniqueErrors.jsx b/app/src/pages/inside/uniqueErrorsPage/emptyUniqueErrors/emptyUniqueErrors.jsx index 600f6b0f54..1a4c293a47 100644 --- a/app/src/pages/inside/uniqueErrorsPage/emptyUniqueErrors/emptyUniqueErrors.jsx +++ b/app/src/pages/inside/uniqueErrorsPage/emptyUniqueErrors/emptyUniqueErrors.jsx @@ -65,76 +65,71 @@ export const EmptyUniqueErrors = ({ parentLaunch }) => { trackEvent(UNIQUE_ERRORS_PAGE_EVENTS.CLICK_RUN_BUTTON); }; - return ( - <> - {loading ? ( - - ) : ( -
-
-
- {clusterActive ? ( - <> -
- -
-

- {formatMessage(messages.inProgressAnalysisText)} -

-
- - {formatMessage(messages.inProgressUniqueErrBtn)} - -
- - ) : ( - <> -

- {canManageItems - ? formatMessage( - lastRunAnalysis - ? messages.noUniqueErrHeadline - : messages.noUniqueErrRunHeadline, - ) - : formatMessage(messages.noUniqueErrYetHeadline)} -

+ const getHeadlineMessage = () => { + if (!canManageItems) { + return formatMessage(messages.noUniqueErrYetHeadline); + } + return lastRunAnalysis + ? formatMessage(messages.noUniqueErrHeadline) + : formatMessage(messages.noUniqueErrRunHeadline); + }; + + const getTextMessage = () => { + if (!canManageItems) { + return formatMessage(messages.emptyUniqueErrTextViewer); + } + return lastRunAnalysis + ? formatMessage(messages.rerunAnalysisText) + : formatMessage(messages.emptyUniqueErrText); + }; + + if (loading) { + return ; + } -

- {canManageItems - ? formatMessage( - lastRunAnalysis ? messages.rerunAnalysisText : messages.emptyUniqueErrText, - ) - : formatMessage(messages.emptyUniqueErrTextViewer)} -

+ return ( +
+
+
+ {clusterActive ? ( + <> +
+ +
+

+ {formatMessage(messages.inProgressAnalysisText)} +

+
+ {formatMessage(messages.inProgressUniqueErrBtn)} +
+ + ) : ( + <> +

{getHeadlineMessage()}

+

{getTextMessage()}

- {canManageItems && ( -
- - {formatMessage(messages.emptyUniqueErrBtn)} - -
- )} - + {canManageItems && ( +
+ + {formatMessage(messages.emptyUniqueErrBtn)} + +
)} -
-
- )} - + + )} +
+
); }; EmptyUniqueErrors.propTypes = { - showModal: PropTypes.func, parentLaunch: PropTypes.object, }; EmptyUniqueErrors.defaultProps = { - showModal: () => {}, parentLaunch: {}, };