EPMRPP-95440 || Code Review fix - 1

reportportal · Sep 23, 2024 · a95acf7 · a95acf7
1 parent 15f3b26
commit a95acf7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/app/src/common/constants/reservedFilterIds.js b/app/src/common/constants/reservedFilterIds.js
@@ -17,4 +17,5 @@
 export const ALL = 'all';
 export const LATEST = 'latest';
 export const NEW_FILTER_PREFIX = 'New_filter';
-export const CUSTOM_FILTER = '-1';
+export const CUSTOM_FILTER_ID = '-1';
+export const CUSTOM_FILTER = 'Custom filter';
diff --git a/app/src/controllers/filter/sagas.js b/app/src/controllers/filter/sagas.js
@@ -36,7 +36,11 @@ import { FETCH_PROJECT_PREFERENCES_SUCCESS } from 'controllers/project/constants
 import { launchDistinctSelector } from 'controllers/launch/selectors';
 import { fetchLaunchesAction } from 'controllers/launch/actionCreators';
 import { omit } from 'common/utils/omit';
-import { NEW_FILTER_PREFIX, CUSTOM_FILTER } from 'common/constants/reservedFilterIds';
+import {
+  NEW_FILTER_PREFIX,
+  CUSTOM_FILTER,
+  CUSTOM_FILTER_ID,
+} from 'common/constants/reservedFilterIds';
 import { redirect } from 'redux-first-router';
 import {
   NAMESPACE,
@@ -138,20 +142,20 @@ function* createFilter({ payload = {}, meta = {} }) {
 
   const filterName = hasFilterPermissions
     ? `${NEW_FILTER_PREFIX} ${-(lastNewFilterId - 1)}`
-    : 'Custom filter';
+    : CUSTOM_FILTER;
 
   const newFilter = {
     ...DEFAULT_FILTER,
     ...filter,
-    id: hasFilterPermissions ? lastNewFilterId - 1 : CUSTOM_FILTER,
+    id: hasFilterPermissions ? lastNewFilterId - 1 : CUSTOM_FILTER_ID,
     name: filter.name ? `${COPY_PREFIX} ${filter.name}` : filterName,
     owner: userId,
   };
   yield put(addFilterAction(newFilter));
   yield put(changeActiveFilterAction(newFilter.id, meta));
 
   if (isRemoveCustomFilter) {
-    yield put(removeLaunchesFilterAction(CUSTOM_FILTER));
+    yield put(removeLaunchesFilterAction(CUSTOM_FILTER_ID));
   }
 }