Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-86865 || Update the twitter logo on the Login page #3614

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

BlazarQSO
Copy link
Contributor

No description provided.

@BlazarQSO BlazarQSO temporarily deployed to development October 23, 2023 01:23 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #3614 (3882afe) into develop (e1eec39) will not change coverage.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3614   +/-   ##
========================================
  Coverage    60.28%   60.28%           
========================================
  Files           78       78           
  Lines          856      856           
  Branches       124      124           
========================================
  Hits           516      516           
  Misses         313      313           
  Partials        27       27           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bam6ycha Bam6ycha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is better to change the CSS properties of SVG on hover, or on click
rather than have three different svgs

Copy link
Contributor

@Bam6ycha Bam6ycha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is better to change the CSS properties of SVG on hover, or on click
rather than have three different svgs

@AmsterGet
Copy link
Member

I think that it is better to change the CSS properties of SVG on hover, or on click rather than have three different svgs

We have a separate task to change this behavior for all social icons, so I suppose it can be done separately.

@Bam6ycha Bam6ycha self-requested a review October 23, 2023 10:55
@AmsterGet AmsterGet merged commit 266ce37 into develop Oct 23, 2023
11 checks passed
@AmsterGet AmsterGet deleted the feature/EPMRPP-86865-update-the-twitter-logo branch October 23, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants