Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-93646 || GA events. Sidebar part 1 #4027

Conversation

maria-hambardzumian
Copy link
Contributor

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.18%. Comparing base (3dfe1f9) to head (68dfea2).

Additional details and impacted files
@@              Coverage Diff              @@
##           feature/orgs    #4027   +/-   ##
=============================================
  Coverage         61.18%   61.18%           
=============================================
  Files                81       81           
  Lines               912      912           
  Branches            130      131    +1     
=============================================
  Hits                558      558           
  Misses              324      324           
  Partials             30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maria-hambardzumian maria-hambardzumian merged commit 7c132aa into feature/orgs Sep 30, 2024
9 of 10 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/EPMRPP-93646-GA-events-Sidebar-part-1 branch September 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants