EPMRPP-96415 || Default number of items per page is displayed when us… #4065
Conversation
…er returns to the page
BlazarQSO
requested review from
AmsterGet and
maria-hambardzumian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/orgs #4065 +/- ##
=============================================
Coverage 61.05% 61.05%
=============================================
Files 82 82
Lines 914 914
Branches 131 130 -1
=============================================
Hits 558 558
Misses 326 326
Partials 30 30 ☔ View full report in Codecov by Sentry. |
| @@ -105,6 +105,7 @@ export const prevPagePropertiesSelector = ( | |||
|
|
|||
| export const createQueryParametersSelector = ({ | |||
| namespace: staticNamespace, | |||
| alternativeNamespace, | |||
There was a problem hiding this comment.
Why the existing staticNamespace cannot be used instead?
There was a problem hiding this comment.
When everyone switches to the same pagination format, then you can leave one option.
| @@ -29,6 +29,7 @@ export const withPagination = ({ | |||
| paginationSelector = defaultPaginationSelector, | |||
| namespace, | |||
| namespaceSelector, | |||
| alternativeNamespace, | |||
There was a problem hiding this comment.
When everyone switches to the same pagination format, then you can leave one option.
|
|
||
| export const totalElementsSelector = (paginationSelector) => (state) => | ||
| paginationSelector(state).totalElements; | ||
| export const totalPagesSelector = (paginationSelector) => (state) => | ||
| paginationSelector(state).totalPages; | ||
|
|
||
| export const defaultPaginationSelector = () => DEFAULT_PAGINATION; | ||
|
|
||
| export const createParametersSelector = ({ |
There was a problem hiding this comment.
As this not related just to pagination, I suggest to move this selector to the pages/selectors and name it as createAlternativeQueryParametersSelector to be consistent in naming.
In this case this alternative common query selector will be responsible for collecting and processing all types of query parameters (pagination, sorting, etc)
| @@ -25,4 +25,5 @@ export const loadingSelector = (state) => domainSelector(state).loading || false | |||
|
|
|||
| export const querySelector = createQueryParametersSelector({ | |||
There was a problem hiding this comment.
Should it be replaced by createAlternativeQueryParametersSelector?
There was a problem hiding this comment.
This is an old pagination and can work via namespace:
But then there will be such parameters:
with an alternative namespace:
|
…er returns to the page
PR Checklist
developfor features/bugfixes, other if mentioned in the task)npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.npm run build)?manage:translationsscript?Visuals