Use trunk for web demo
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Jun 5, 2024
emilk
reviewed
Jun 5, 2024
emilk
reviewed
Jun 5, 2024
|
@emilk I think it's correct now ? Btw I made this PR: https://github.com/emilk/eframe_template/pull/137/files |
This was referenced Jun 26, 2024
emilk
pushed a commit
to emilk/eframe_template
that referenced
this pull request
Jun 27, 2024
## Bug: assets have incorrect paths Proof: ``` git clone https://github.com/emilk/eframe_template.git && lychee . ``` ``` 31/31 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links Issues found in 1 input. Find details below. [./eframe_template/index.html]: ✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/icon_ios_touch_192.png | Failed: Cannot find file ✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/manifest.json | Failed: Cannot find file 🔍 31 Total (in 0s) ✅ 29 OK 🚫 2 Errors ``` ## Fix change links to these assets ## Related to - #137 - related to rerun-io/ewebsock#38 (comment)
emilk
reviewed
Jul 15, 2024
Hasenfellvy
added a commit
to Hasenfellvy/eframe_template
that referenced
this pull request
Aug 27, 2024
## Bug: assets have incorrect paths Proof: ``` git clone https://github.com/emilk/eframe_template.git && lychee . ``` ``` 31/31 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links Issues found in 1 input. Find details below. [./eframe_template/index.html]: ✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/icon_ios_touch_192.png | Failed: Cannot find file ✗ [ERR] file:///tmp/tmp.xuDXKdo4H8/eframe_template/manifest.json | Failed: Cannot find file 🔍 31 Total (in 0s) ✅ 29 OK 🚫 2 Errors ``` ## Fix change links to these assets ## Related to - emilk/eframe_template#137 - related to rerun-io/ewebsock#38 (comment)
|
any news on it ? |
emilk
approved these changes
Oct 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options::additional_headersandsubprotocols#27