Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct eframe options for our custom viewer examples #8616

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Use the correct eframe options for our custom viewer examples #8616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abd30c8
Use the correct eframe olptions for our custom viewer examples
emilk Jan 8, 2025
5f0338b
Remove unused dep
emilk Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/rust/custom_callback/src/viewer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use custom_callback::{comms::viewer::ControlViewer, panel::Control};

use rerun::external::{eframe, egui, re_log, re_memory, re_sdk_comms, re_viewer};
use rerun::external::{eframe, re_log, re_memory, re_sdk_comms, re_viewer};

use std::net::Ipv4Addr;

Expand Down Expand Up @@ -42,10 +42,10 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
});

// Then we start the Rerun viewer
let native_options = eframe::NativeOptions {
viewport: egui::ViewportBuilder::default().with_app_id("rerun_custom_callback_example"),
..re_viewer::native::eframe_options(None)
};
let mut native_options = re_viewer::native::eframe_options(None);
native_options.viewport = native_options
.viewport
.with_app_id("rerun_custom_callback_example");

// This is used for analytics, if the `analytics` feature is on in `Cargo.toml`
let app_env = re_viewer::AppEnvironment::Custom("My Custom Callback".to_owned());
Expand Down
8 changes: 4 additions & 4 deletions examples/rust/extend_viewer_ui/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
Default::default(),
)?;

let native_options = eframe::NativeOptions {
viewport: egui::ViewportBuilder::default().with_app_id("rerun_extend_viewer_ui_example"),
..re_viewer::native::eframe_options(None)
};
let mut native_options = re_viewer::native::eframe_options(None);
native_options.viewport = native_options
.viewport
.with_app_id("rerun_extend_viewer_ui_example");

let startup_options = re_viewer::StartupOptions::default();

Expand Down
Loading