Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arrow, pyo3, and numpy #8618

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update arrow, pyo3, and numpy #8618

wants to merge 2 commits into from

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 8, 2025

There were a few scary changes to rerun_py/src/dataframe.rs - do we have automated testing for that?

@emilk emilk added dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🏹 arrow concerning arrow labels Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
a1837c6 https://rerun.io/viewer/pr/8618 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk marked this pull request as ready for review January 8, 2025 19:59
@emilk emilk requested a review from jleibs January 8, 2025 20:00
@emilk emilk added the do-not-merge Do not merge this PR label Jan 8, 2025
@jleibs
Copy link
Member

jleibs commented Jan 8, 2025

There were a few scary changes to rerun_py/src/dataframe.rs - do we have automated testing for that?

Not totally comprehensive, but there's partial coverage in: https://github.com/rerun-io/rerun/blob/71215dbc5e75ab476077ad203350da4ef7a2d793/rerun_py/tests/unit/test_dataframe.py

@emilk emilk added the blocked can't make progress right now label Jan 9, 2025
@emilk emilk marked this pull request as draft January 9, 2025 09:16
emilk added a commit that referenced this pull request Jan 9, 2025
* Part of #3741
* Requires rerun-io/re_arrow2#15

NOTE: this will regress on memory use, because we lack `.shrink_to_fit`,
which will arrive in
* #8618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow blocked can't make progress right now dependencies concerning crates, pip packages etc do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants