Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .gitignore ignoring crates/build #8621

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix .gitignore ignoring crates/build #8621

merged 1 commit into from
Jan 8, 2025

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Jan 8, 2025 •
edited
Loading

The build/ and ./build/ seemed to both be matching the wrong things. Changed it to /build/:

$ git check-ignore -v -- ./build/debug
.gitignore:9:/build/    ./build/debug
$ git check-ignore -v -- ./crates/build
<empty>

@jprochazk jprochazk changed the title Update .gitignore Fix .gitignore ignoring crates/build Jan 8, 2025
emilk
emilk approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@jprochazk jprochazk added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Jan 8, 2025
@jprochazk jprochazk merged commit 1f0b514 into main Jan 8, 2025
31 of 33 checks passed
@jprochazk jprochazk deleted the jan/fix-ignore-cpp-build branch January 8, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jprochazk @emilk