Improve error message when an object is passed where a record is expected #7101
Conversation
zth
force-pushed
the
error-msg-pass-object-to-record
branch
from
0bb7d09
to
c45700e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Syntax Benchmarks
| Benchmark suite | Current: c45700e | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.2079324133333333 ms |
1.2123143266666667 ms |
1.00 |
Parse RedBlackTree.res - allocs/run |
199057 words |
199057 words |
1 |
Print RedBlackTree.res - time/run |
2.31255812 ms |
2.3104395133333333 ms |
1.00 |
Print RedBlackTree.res - allocs/run |
236403 words |
236403 words |
1 |
Print RedBlackTreeNoComments.res - time/run |
2.085011106666667 ms |
2.10057036 ms |
0.99 |
Print RedBlackTreeNoComments.res - allocs/run |
249186 words |
249186 words |
1 |
Parse Napkinscript.res - time/run |
39.036746519999994 ms |
39.28006235333333 ms |
0.99 |
Parse Napkinscript.res - allocs/run |
8670066 words |
8670066 words |
1 |
Print Napkinscript.res - time/run |
75.60905208 ms |
77.00100409999999 ms |
0.98 |
Print Napkinscript.res - allocs/run |
9776327 words |
9776327 words |
1 |
Parse HeroGraphic.res - time/run |
5.09393054 ms |
5.13472718 ms |
0.99 |
Parse HeroGraphic.res - allocs/run |
1219326 words |
1219326 words |
1 |
Print HeroGraphic.res - time/run |
8.713838513333334 ms |
8.775952553333333 ms |
0.99 |
Print HeroGraphic.res - allocs/run |
1396466 words |
1396466 words |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
@cknitt consistency looks surprisingly good. |
It might be nice to have the benchmark outputs always visible. So that
|
This improves the error message when an object is passed where a record is expected. A scenario that happens from time to time when copy pasting JS/TS stuff.