Fix gentype jsx issue #7107
Merged
Fix gentype jsx issue #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7103 The Jsx.element type has moved from Pervasives.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Syntax Benchmarks
| Benchmark suite | Current: 443e688 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.2398907533333332 ms |
1.2123143266666667 ms |
1.02 |
Parse RedBlackTree.res - allocs/run |
199057 words |
199057 words |
1 |
Print RedBlackTree.res - time/run |
2.3386479799999997 ms |
2.3104395133333333 ms |
1.01 |
Print RedBlackTree.res - allocs/run |
236403 words |
236403 words |
1 |
Print RedBlackTreeNoComments.res - time/run |
2.0988734066666668 ms |
2.10057036 ms |
1.00 |
Print RedBlackTreeNoComments.res - allocs/run |
249186 words |
249186 words |
1 |
Parse Napkinscript.res - time/run |
39.0237255 ms |
39.28006235333333 ms |
0.99 |
Parse Napkinscript.res - allocs/run |
8670066 words |
8670066 words |
1 |
Print Napkinscript.res - time/run |
72.70350768666665 ms |
77.00100409999999 ms |
0.94 |
Print Napkinscript.res - allocs/run |
9776327 words |
9776327 words |
1 |
Parse HeroGraphic.res - time/run |
5.079912879999999 ms |
5.13472718 ms |
0.99 |
Parse HeroGraphic.res - allocs/run |
1219326 words |
1219326 words |
1 |
Print HeroGraphic.res - time/run |
8.607115866666666 ms |
8.775952553333333 ms |
0.98 |
Print HeroGraphic.res - allocs/run |
1396466 words |
1396466 words |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt
reviewed
Oct 19, 2024
| @@ -207,7 +207,8 @@ let translate_constr ~config ~params_translation ~(path : Path.t) ~type_env = | |||
| {dependencies = []; type_ = EmitType.type_react_event_mouse_t} | |||
| | ( ( ["React"; "element"] | |||
| | ["ReasonReact"; "reactElement"] | |||
There was a problem hiding this comment.
@cristianoc I think ReasonReact.reactElement could be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7106
The Jsx.element type has moved from Pervasives.