WIP: Move core typedefs out of Js modules #7129
Draft
+29
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
core-typedefs
branch
4 times, most recently
from
830ec22
to
5828460
Compare
cknitt
changed the title
Henrryxdjr
approved these changes
Oct 25, 2024
|
The approach in this PR works fine for me. As mentioned, I had issues when putting the typedefs directly into the individual Core modules, see #7126 (comment). Done so far for date and regExp, shall I continue this way for the other types @cristianoc @zth ? |
The questions is what we want to expose to the user when hovering. @zth ? |
@cristianoc @zth Hover would currently look like this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.