C4 Mitigations - 2024-07 #3896
akshatmittaltests.yml
on: pull_request
Deployment Scripts
9m 44s
Lint Checks
13m 14s
Plugin Unit Tests
9m 35s
Plugin Integration Tests (Mainnet) - 1/3
48m 34s
Plugin Integration Tests (Mainnet) - 2/3
23m 6s
Plugin Integration Tests (Mainnet) - 3/3
33m 19s
Plugin Integration Tests (Base)
11m 35s
Plugin Integration Tests (Arbitrum)
17m 10s
P0 tests
18m 17s
P1 Tests
16m 37s
Scenario Tests
8m 34s
Extreme Tests
46m 30s
Integration Tests
8m 26s
Monitor Tests (Mainnet)
6m 15s
Registry Tests
2m 12s
Annotations
2 errors and 24 warnings
|
Plugin Integration Tests (Mainnet) - 1/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 1/3
The operation was canceled.
|
|
Integration Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Deployment Scripts
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Extreme Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
P0 tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Arbitrum)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Monitor Tests (Mainnet)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
P1 Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Mainnet) - 2/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Base)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Integration Tests (Mainnet) - 3/3
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Registry Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Scenario Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
|
Lint Checks:
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
|
|
Lint Checks:
contracts/p0/Deployer.sol#L180
Code contains empty blocks
|
|
Lint Checks:
contracts/p1/Main.sol#L158
Avoid to use low level calls
|
|
Lint Checks:
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase
|