C4 Mitigations - 2024-07 #3910
Triggered via pull request
September 10, 2024 18:58
akshatmittal
Status
Cancelled
Total duration
1m 1s
Artifacts
–
tests.yml
on: pull_request
Deployment Scripts
47s
Lint Checks
47s
Plugin Unit Tests
46s
Plugin Integration Tests (Mainnet) - 1/3
47s
Plugin Integration Tests (Mainnet) - 2/3
47s
Plugin Integration Tests (Mainnet) - 3/3
47s
Plugin Integration Tests (Base)
47s
Plugin Integration Tests (Arbitrum)
48s
P0 tests
48s
P1 Tests
47s
Scenario Tests
45s
Extreme Tests
51s
Integration Tests
48s
Monitor Tests (Mainnet)
48s
Registry Tests
46s
Annotations
30 errors and 10 warnings
|
Scenario Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Scenario Tests
The operation was canceled.
|
|
Registry Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Extreme Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Registry Tests
The operation was canceled.
|
|
Extreme Tests
The operation was canceled.
|
|
Deployment Scripts
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Deployment Scripts
The operation was canceled.
|
|
P1 Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
P1 Tests
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 3/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 3/3
The operation was canceled.
|
|
Plugin Unit Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Unit Tests
The operation was canceled.
|
|
Lint Checks
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Lint Checks
The operation was canceled.
|
|
Monitor Tests (Mainnet)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Monitor Tests (Mainnet)
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 2/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 1/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 2/3
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 1/3
The operation was canceled.
|
|
P0 tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
P0 tests
The operation was canceled.
|
|
Plugin Integration Tests (Base)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Base)
The operation was canceled.
|
|
Plugin Integration Tests (Arbitrum)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Arbitrum)
The operation was canceled.
|
|
Integration Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Integration Tests
The operation was canceled.
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
|
Lint Checks:
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
|
|
Lint Checks:
contracts/p0/Deployer.sol#L179
Code contains empty blocks
|
|
Lint Checks:
contracts/p1/Broker.sol#L40
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/p1/Main.sol#L158
Avoid to use low level calls
|