C4 Mitigations - 2024-07 #3911
Triggered via pull request
September 10, 2024 18:59
akshatmittal
Status
Cancelled
Total duration
17m 1s
Artifacts
–
tests.yml
on: pull_request
Deployment Scripts
10m 55s
Lint Checks
12m 44s
Plugin Unit Tests
10m 20s
Plugin Integration Tests (Mainnet) - 1/3
16m 28s
Plugin Integration Tests (Mainnet) - 2/3
16m 29s
Plugin Integration Tests (Mainnet) - 3/3
16m 29s
Plugin Integration Tests (Base)
13m 1s
Plugin Integration Tests (Arbitrum)
16m 28s
P0 tests
16m 15s
P1 Tests
16m 31s
Scenario Tests
9m 29s
Extreme Tests
16m 30s
Integration Tests
10m 39s
Monitor Tests (Mainnet)
3m 14s
Registry Tests
2m 9s
Annotations
13 errors and 18 warnings
|
P0 tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Extreme Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Extreme Tests
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 1/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 1/3
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 3/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 3/3
The operation was canceled.
|
|
Plugin Integration Tests (Arbitrum)
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Arbitrum)
The operation was canceled.
|
|
Plugin Integration Tests (Mainnet) - 2/3
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
Plugin Integration Tests (Mainnet) - 2/3
The operation was canceled.
|
|
P1 Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1204/merge' exists
|
|
P1 Tests
The operation was canceled.
|
|
Registry Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Monitor Tests (Mainnet)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Scenario Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Plugin Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Integration Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Deployment Scripts
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
|
Lint Checks:
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
|
Lint Checks:
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint Checks:
contracts/p0/AssetRegistry.sol#L128
Code contains empty blocks
|
|
Lint Checks:
contracts/p0/Deployer.sol#L179
Code contains empty blocks
|
|
Lint Checks:
contracts/p1/Broker.sol#L40
Variable name must be in mixedCase
|
|
Lint Checks:
contracts/p1/Main.sol#L158
Avoid to use low level calls
|
|
Plugin Integration Tests (Base)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|