Skip to content

improve recollat docs #3923

improve recollat docs

improve recollat docs #3923

Triggered via pull request September 18, 2024 22:31
Status Success
Total duration 51m 8s
Artifacts

tests.yml

on: pull_request
Deployment Scripts
10m 7s
Deployment Scripts
Lint Checks
13m 15s
Lint Checks
Plugin Unit Tests
6m 25s
Plugin Unit Tests
Plugin Integration Tests (Mainnet) - 1/2
50m 55s
Plugin Integration Tests (Mainnet) - 1/2
Plugin Integration Tests (Mainnet) - 2/2
30m 20s
Plugin Integration Tests (Mainnet) - 2/2
Plugin Integration Tests (Base)
7m 44s
Plugin Integration Tests (Base)
Plugin Integration Tests (Arbitrum)
12m 25s
Plugin Integration Tests (Arbitrum)
P0 tests
16m 11s
P0 tests
P1 Tests
15m 39s
P1 Tests
Scenario Tests
7m 45s
Scenario Tests
Extreme Tests
36m 57s
Extreme Tests
Integration Tests
9m 47s
Integration Tests
Monitor Tests (Mainnet)
6m 29s
Monitor Tests (Mainnet)
Fit to window
Zoom out
Zoom in

Annotations

23 warnings
Plugin Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Monitor Tests (Mainnet)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Base)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Scenario Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Integration Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deployment Scripts
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Arbitrum)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint Checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Lint Checks: contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
Lint Checks: contracts/facade/Facade.sol#L30
Fallback function must be simple
Lint Checks: contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L47
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L112
Variable name must be in mixedCase
Lint Checks: contracts/facade/facets/RevenueFacet.sol#L113
Avoid to use inline assembly. It is acceptable only in rare cases
Lint Checks: contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase
Lint Checks: contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L10
Variable name must be in mixedCase
Lint Checks: contracts/plugins/assets/curve/PoolTokens.sol#L17
Variable name must be in mixedCase
P1 Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
P0 tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Mainnet) - 2/2
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Extreme Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Plugin Integration Tests (Mainnet) - 1/2
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/